Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add noDynamicTableData props for which the entire data can be rendered even if the table data source goes beyond the pageSize of the page #49160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seung-juv
Copy link

@seung-juv seung-juv commented May 31, 2024

Add noDynamicTableData props for which the entire data can be rendered even if the table data source goes beyond the pageSize of the page

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Support noDynamicTableData in Table
🇨🇳 Chinese 支持表中的 noDynamicTableData

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Add noDynamicTableData props for which the entire data can be rendered even if the table data source goes beyond the pageSize of the page
Copy link

stackblitz bot commented May 31, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented May 31, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented May 31, 2024

👁 Visual Regression Report for PR #49160 Passed ✅

🎯 Target branch: master (664f3e6)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.99%. Comparing base (664f3e6) to head (37c41c4).

Files Patch % Lines
components/table/InternalTable.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master   #49160      +/-   ##
===========================================
- Coverage   100.00%   99.99%   -0.01%     
===========================================
  Files          745      745              
  Lines        12974    12976       +2     
  Branches      3401     3402       +1     
===========================================
+ Hits         12974    12975       +1     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant