added metaData, streamName to HandshakeMessage package. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod: Introduced 'AntPeer' struct to manage peers more efficiently, replacing the streamId list with a versatile list of 'AntPeer' instances. Updated 'HandshakeMessage' struct by adding 'metaData' and 'streamName' fields for improved functionality. Refactored 'publishMessage' method for clearer publishing using 'AntPeer' instances. These changes collectively enhance peer management, align package structures, and simplify the publishing process. Code updates and package modifications complete. Ready for pull request! Feel free to make changes as needed. But please maintain the idea which is to send the streamName and metaData alongside streamId.
MuhammadjonTohirov
changed the title
|
Thank you @MuhammadjonTohirov for your contributions. I appreciate it. 👏 I'll try to merge in my convenient time |
|
Hi @mekya, I appreciate that you responded to 'pull request'. Can you look through and do something about it. It would be great if you merged it to main repository. |
|
Hi @MuhammadjonTohirov , Thank you. I've added this to my todo list to review and merge. Thank you for your contribution. Please add me on linkedin if it's possible. |
Conflicts: WebRTCiOSSDK/api/AntMediaClient.swift
Conflicts: WebRTCiOSSDK/api/AntMediaClient.swift
…data send current status in onpacket mic, cam, pin, screenshare
…data sendData WebRTCClient now checking for iceConnectionState
MuhammadjonTohirov
force-pushed
the
feature-streamname-metadata
branch
from
ee1df43
to
679b0bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced Peer Handling, Package Updates, and Refactored Publishing Method: Introduced 'AntPeer' struct to manage peers more efficiently, replacing the streamId list with a versatile list of 'AntPeer' instances. Updated 'HandshakeMessage' struct by adding 'metaData' and 'streamName' fields for improved functionality. Refactored 'publishMessage' method for clearer publishing using 'AntPeer' instances. These changes collectively enhance peer management, align package structures, and simplify the publishing process. Code updates and package modifications complete. Ready for pull request!
Feel free to make changes as needed. But please maintain the idea which is to send the streamName and metaData alongside streamId.