Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor speed test #376

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Refactor speed test #376

wants to merge 12 commits into from

Conversation

mustafaboleken
Copy link
Contributor

@mustafaboleken mustafaboleken commented Oct 22, 2024

#358

This pull request removes the mechanism to publish a stream before making play speed test for the play only users.
Instead of publishing and playing in the client side, it tries to play a "static" streamId which is called speedTestSampleStream in the same Ant Media Server application. Using a static stream reduces the load on the server side in case there are so much new play only users. I will add a mechanism to add a playlist and use the speedTestSampleStream streamId if there is no stream with id speedTestSampleStream

@mustafaboleken mustafaboleken linked an issue Oct 22, 2024 that may be closed by this pull request
2 tasks
@mustafaboleken mustafaboleken marked this pull request as draft October 22, 2024 06:41
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.49%. Comparing base (b3b5f29) to head (2a07242).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   49.49%   49.49%           
=======================================
  Files          22       22           
  Lines        2174     2174           
  Branches      487      487           
=======================================
  Hits         1076     1076           
  Misses        958      958           
  Partials      140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mustafaboleken mustafaboleken marked this pull request as ready for review October 23, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Circle] Speed test refactor
1 participant