fix: navigate to other collection page with query #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
reviewed
Apr 7, 2024
| @@ -47,7 +47,7 @@ const collections = computed(() => { | |||
| </div> | |||
|
|
|||
| <!-- Collections --> | |||
| <RouterLink | |||
| <QueryRouterLink | |||
There was a problem hiding this comment.
I wonder why you end up with this solution? I would avoid patching built-in components as much as possible (also it would cause problem if we forget to use the patched version in future changes)
There was a problem hiding this comment.
Indeed, patched component shouldn't be used here. How about handling this in the collection/[id].vue file with the onBeforeRouteUpdate hook? If navigating to another collection and the before route with a query, it will overwrite the current route query.
As for the click event problem, the RouterLink with the click handler is not frequently used. How about also removing the patched component?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues
#300
Additional context