[RuntimeEnv] Add archives plugin in Runtime Env module #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackyMa1997
changed the title
…ontext (#501) Signed-off-by: sule <[email protected]>
wumuzi520
requested changes
Feb 17, 2025
| # - test_1.txt | ||
| # - test_1: | ||
| # - test_1.txt | ||
| archive_url = "http://raylet.cn-hangzhou-alipay-b.oss-cdn.aliyun-inc.com/test_runtime_env/test.zip" # noqa: E501 |
There was a problem hiding this comment.
This url can not be accessed.
| if archive_uris != "": | ||
| return [archive_uris] | ||
| return [] | ||
| elif isinstance(archive_uris, dict): |
There was a problem hiding this comment.
what is the dict looks like?
wumuzi520
requested changes
Feb 17, 2025
| @@ -240,7 +240,7 @@ def __init__( | |||
| self._mpi_plugin, | |||
| self._image_uri_plugin, | |||
| ] | |||
| self._plugin_manager = RuntimeEnvPluginManager() | |||
| self._plugin_manager = RuntimeEnvPluginManager(self._runtime_env_dir) | |||
There was a problem hiding this comment.
Why we need add the extra parameter
There was a problem hiding this comment.
Why we need add the extra parameter
RuntimeEnv New plugin need runtime env dir from runtime env plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add Archives plugin in Runtime Env module #504
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.