Add env, preCommand, and skipGitConfigProtection config options #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These features enable integration with external security proxies: - `env`: Custom environment variables to set inside the sandbox. Useful for passing CA certificate paths when using MITM proxies. - `preCommand`: Shell command to run after network bridges are established but before the user command. Useful for initialization tasks. - `skipGitConfigProtection`: Skip mandatory blocking of .git/config and .git/hooks writes. Enable only when using an external security proxy that already protects against git config exploits (core.fsmonitor, etc.). Also updates generateProxyEnvVars() to accept custom env vars and wires everything through the Linux sandbox path. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Collaborator
Author
|
@ddworken @ollie-anthropic I'll fix the merge conflicts, but for now just looking to understand if this is in the right direction / if there's any structural feedback. my high level goal is to reuse the sandboxing part, but make it so I can point to a different network proxy instead of the built-in one. Code does seem to work on my machine in my test env, but n=1 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These features enable integration with external security proxies:
env: Custom environment variables to set inside the sandbox. Useful for passing CA certificate paths when using MITM proxies.preCommand: Shell command to run after network bridges are established but before the user command. Useful for initialization tasks.skipGitConfigProtection: Skip mandatory blocking of .git/config and .git/hooks writes. Enable only when using an external security proxy that already protects against git config exploits (core.fsmonitor, etc.).Also updates generateProxyEnvVars() to accept custom env vars and wires everything through the Linux sandbox path.
🤖 Generated with Claude Code