Skip to content

Reject a non-string target_agent instead of raising TypeError #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LibertasSpZ wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

Reject a non-string target_agent instead of raising TypeError #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/orchestrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,10 @@ def extract_handoff(text: str, source_agent: str = "unknown") -> dict | None:

target = obj.get("target_agent")
payload = obj.get("payload")
if target not in ALLOWED_TARGETS:
# The type check comes first because the blob is attacker-influenced: a
# JSON array or object here is unhashable, and set membership would raise
# TypeError out of run()'s stream loop instead of rejecting the handoff.
if not isinstance(target, str) or target not in ALLOWED_TARGETS:
audit_log({"source": source_agent, "target": target,
"result": "reject", "reason": "target_not_allowlisted",
"raw_len": raw_len})
Expand Down