Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inserting after the last line of a file without a trailing newline concatenates the inserted text to that line. Add the missing separator before inserting. Tests cover an unterminated last line, an already terminated line, insertion at the beginning, and an empty file.
Validation:
PYTHONPATH=computer-use-best-practices/ python -m pytest computer-use-best-practices/tests/test_editor.py -q(14 passed in 0.55s). The regression tests fail on the unchanged main branch. Tests use local fixtures; no paid API calls.Prepared with Codex assistance; the final diff and regression behavior were checked locally.