Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image-size search assumes a valid one-pixel lower bound. Nonpositive limits violate that assumption: a one-pixel image with max_tokens=0 never terminates, and larger inputs can return dimensions that exceed the requested cap. Reject nonpositive dimensions and sizing limits before the search. The hang regression runs in a child process with a timeout; ordinary valid sizing cases remain covered.
Validation:
PYTHONPATH=computer-use-best-practices/ python -m pytest computer-use-best-practices/tests/test_image.py -q(18 passed in 0.54s). The regression tests fail on the unchanged main branch. Tests use local fixtures; no paid API calls.Additional checks:
ruff check computer-use-best-practices/tests/test_image.py computer-use-best-practices/computer_use/image.py,ruff format --check computer-use-best-practices/tests/test_image.py computer-use-best-practices/computer_use/image.py.Prepared with Codex assistance; the final diff and regression behavior were checked locally.