manifest: recognize disabled_models / additional_models config keys - #294
Closed
jmm-ant wants to merge 2 commits into
Closed
manifest: recognize disabled_models / additional_models config keys#294jmm-ant wants to merge 2 commits into
jmm-ant wants to merge 2 commits into
Conversation
The add-in reads available_models on third-party deployments: the list of models the picker offers, replacing the catalog baked into the build. Without registering it here the install script rejects it with "unknown key". It accepts a JSON array or a comma list on all three config channels. It needs its own pattern rather than reusing disabled_features': model ids carry . : @ - characters that the feature-slug pattern rejects, so admins would get a spurious warning on every valid value. Document it as a manifest param, a bootstrap field, and a per-user extension attribute, including that setting it pins the deployment to the list, and that in Outlook it may only narrow the picker, never extend it. No-Verification-Needed: docs + validator entry, no runtime surface; verified by running build-manifest.mjs end-to-end and unit-testing the pattern against real provider-form ids
jmm-ant
force-pushed
the
jmm/model-picker-config-keys
branch
from
July 17, 2026 20:48
fa5108e to
3237141
Compare
mihilmy
previously approved these changes
Jul 23, 2026
…ON channels The comma (Entra) channel carries bare ids only; the JSON forms accept objects so admins can control the picker label for internal gateway ids.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The add-in now reads two config keys that shape the model picker on third-party deployments: disabled_models hides ids, additional_models offers ids beyond the catalog baked into the build. Without registering them here the install script rejects them with "unknown key".
Both accept a JSON array or a comma list on all three config channels. They need their own pattern rather than reusing disabled_features': model ids carry . : @ - characters that the feature-slug pattern rejects, so admins would get a spurious warning on every valid value.
Document the keys as manifest params, bootstrap fields, and per-user extension attributes, including the precedence rule (disabled wins) and that both are inert in Outlook, where the mail safety gate pins the surface to a vetted model.
No-Verification-Needed: docs + validator entry, no runtime surface; verified by running build-manifest.mjs end-to-end and unit-testing the new pattern