fix(financial-analysis): repair invalid .mcp.json; lint MCP configs in check.py - #300
Open
koreydillon wants to merge 1 commit into
Open
fix(financial-analysis): repair invalid .mcp.json; lint MCP configs in check.py#300koreydillon wants to merge 1 commit into
koreydillon wants to merge 1 commit into
Conversation
…ks.json in check.py The financial-analysis .mcp.json was missing a comma after the egnyte entry and the closing brace on box, so the file failed to parse and none of the plugin's 12 MCP connectors could load. scripts/check.py did not cover .mcp.json or hooks.json, which is how the broken file passed the local check (OK, 80 files, 0 issues). Added both globs to the JSON parse pass; check.py now fails on the pre-fix file and passes after (90 files checked). Bumped financial-analysis to 0.1.2 per the version-bump rule.
Author
|
Found this while auditing the repo for a client enablement program. Happy to follow up on the mcp-categories.json doc drift noted in the description too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(financial-analysis): repair invalid
.mcp.json; extendcheck.pyto lint MCP and hooks configsWhat
plugins/vertical-plugins/financial-analysis/.mcp.jsonwas invalid JSON. A missing comma after theegnyteentry and a missing closing brace onboxmeant the file failed to parse, so none of the plugin's 12 MCP connectors (Daloopa, Morningstar, S&P Global, FactSet, Moody's, MT Newswires, Aiera, LSEG, PitchBook, Chronograph, Egnyte, Box) could load. Since financial-analysis is the recommended first install, this affects every fresh setup that follows the README.scripts/check.pycoveredplugin.json,marketplace.json, andsteering-examples.jsonbut not.mcp.jsonorhooks.json, which is how the broken file shipped whilecheck.pyreportedOK, 80 files, 0 issues. Added both globs to the existing JSON parse pass (section 2), matching the current style. File count goes 80 to 90.0.1.1to0.1.2per the repo's version-bump rule so already-installed users receive the fix.Verification
Also confirmed
json.loadsucceeds on the repaired file and returns all 12 servers.Notes
check.pybeyond the two added globs.CLAUDE.mdlistsmcp-categories.jsonas a key file, and that file does not exist in the repo. Happy to address in a follow-up if you confirm whether it should be added or the doc line removed.