Skip to content

fix(financial-analysis): repair invalid .mcp.json; lint MCP configs in check.py - #300

Open
koreydillon wants to merge 1 commit into
anthropics:mainfrom
koreydillon:fix/financial-analysis-mcp-json
Open

fix(financial-analysis): repair invalid .mcp.json; lint MCP configs in check.py#300
koreydillon wants to merge 1 commit into
anthropics:mainfrom
koreydillon:fix/financial-analysis-mcp-json

Conversation

@koreydillon

Copy link
Copy Markdown

fix(financial-analysis): repair invalid .mcp.json; extend check.py to lint MCP and hooks configs

What

  • Fix: plugins/vertical-plugins/financial-analysis/.mcp.json was invalid JSON. A missing comma after the egnyte entry and a missing closing brace on box meant the file failed to parse, so none of the plugin's 12 MCP connectors (Daloopa, Morningstar, S&P Global, FactSet, Moody's, MT Newswires, Aiera, LSEG, PitchBook, Chronograph, Egnyte, Box) could load. Since financial-analysis is the recommended first install, this affects every fresh setup that follows the README.
  • Prevention: scripts/check.py covered plugin.json, marketplace.json, and steering-examples.json but not .mcp.json or hooks.json, which is how the broken file shipped while check.py reported OK, 80 files, 0 issues. Added both globs to the existing JSON parse pass (section 2), matching the current style. File count goes 80 to 90.
  • Version: bumped financial-analysis 0.1.1 to 0.1.2 per the repo's version-bump rule so already-installed users receive the fix.

Verification

# before fix, with new check
FAIL — 1 issue(s) across 90 file(s):
  ✗ JSON parse: plugins/vertical-plugins/financial-analysis/.mcp.json:
    Expecting ',' delimiter: line 47 column 5 (char 1100)

# after fix
OK — 90 file(s) checked, 0 issues.

Also confirmed json.load succeeds on the repaired file and returns all 12 servers.

Notes

  • No behavior change to check.py beyond the two added globs.
  • Unrelated but observed while auditing: CLAUDE.md lists mcp-categories.json as a key file, and that file does not exist in the repo. Happy to address in a follow-up if you confirm whether it should be added or the doc line removed.

…ks.json in check.py

The financial-analysis .mcp.json was missing a comma after the egnyte
entry and the closing brace on box, so the file failed to parse and none
of the plugin's 12 MCP connectors could load.

scripts/check.py did not cover .mcp.json or hooks.json, which is how the
broken file passed the local check (OK, 80 files, 0 issues). Added both
globs to the JSON parse pass; check.py now fails on the pre-fix file and
passes after (90 files checked).

Bumped financial-analysis to 0.1.2 per the version-bump rule.
@koreydillon

Copy link
Copy Markdown
Author

Found this while auditing the repo for a client enablement program. Happy to follow up on the mcp-categories.json doc drift noted in the description too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant