fix(financial-analysis): repair malformed .mcp.json that silently drops all 12 connectors - #303
Open
knym wants to merge 1 commit into
Open
fix(financial-analysis): repair malformed .mcp.json that silently drops all 12 connectors#303knym wants to merge 1 commit into
knym wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
plugins/vertical-plugins/financial-analysis/.mcp.jsonis not valid JSON. Theegnyteentry is missing its trailing comma and theboxobject is never closed:python3 -c "import json; json.load(open(...))"fails withExpecting ',' delimiter: line 47 column 5. This is the only invalid JSON file underplugins/.Impact
All 12 data connectors are silently dropped. Installation succeeds with no error or warning, so a user who has paid for FactSet / PitchBook / Moody's / LSEG / S&P Global / Morningstar / Daloopa access has no way to tell the connectors were never registered — the skills just behave as if no data source exists.
Verified by installing the plugin from an otherwise identical local marketplace, with and without this fix:
claude plugin detailsreportsmainMCP servers (0)MCP servers (12) daloopa, morningstar, sp-global, factset, moodys, mtnewswire, aiera, lseg, pitchbook, chronograph, egnyte, boxReproduce on current
main:claude plugin marketplace add anthropics/financial-services claude plugin install financial-analysis@claude-for-financial-services claude plugin details financial-analysis@claude-for-financial-services # MCP servers (0)Fix
Add the missing comma and close the
boxobject. Two lines, no behavior change beyond the connectors loading as intended.Why CI did not catch this
.github/workflows/plugin-validate.ymlrunsclaude plugin validate <plugin_dir>, which only validates.claude-plugin/plugin.json—.mcp.jsonis not checked. On currentmain:Not addressed in this PR to keep it minimal, but adding a
json.loadpass over everyplugins/**/.mcp.jsonto the validate workflow would prevent a recurrence.