Skip to content

fix: repair invalid JSON in financial-analysis/.mcp.json - #328

Open
xinfenguc-glitch wants to merge 1 commit into
anthropics:mainfrom
xinfenguc-glitch:fix/financial-analysis-mcp-json-syntax
Open

fix: repair invalid JSON in financial-analysis/.mcp.json#328
xinfenguc-glitch wants to merge 1 commit into
anthropics:mainfrom
xinfenguc-glitch:fix/financial-analysis-mcp-json-syntax

Conversation

@xinfenguc-glitch

Copy link
Copy Markdown

Problem

plugins/vertical-plugins/financial-analysis/.mcp.json is not valid JSON. The egnyte entry is missing its trailing comma, and the box object is never closed:

    "egnyte": {
      "type": "http",
      "url": "https://mcp-server.egnyte.com/mcp"
    }          <-- missing comma
    "box": {
      "type": "http",
      "url": "https://mcp.box.com"
  }            <-- box never closed
}
$ python -c "import json; json.load(open('.mcp.json'))"
json.decoder.JSONDecodeError: Expecting ',' delimiter: line 47 column 5 (char 1100)

Because the file never parses, none of the 12 MCP servers this plugin declares are registered — the plugin installs and loads cleanly, so the failure is silent. Users get financial-analysis with its skills and commands intact but no data connectivity at all.

Fix

Adds the missing comma and the missing closing brace. Two characters; no server definition is added, removed, or modified, and CRLF line endings are preserved.

Verification

$ python -c "import json; d=json.load(open('.mcp.json')); print(len(d['mcpServers']), 'servers')"
12 servers

All 12 parse: daloopa, morningstar, sp-global, factset, moodys, mtnewswire, aiera, lseg, pitchbook, chronograph, egnyte, box.

Related

Reported three times independently, all still open: #264 (Jun 3), #273 (Jun 13), #292 (Aug 8).

Two adjacent problems are not addressed here, since both look like maintainer calls rather than typo fixes:

  • Agent tool allowlists reference MCP servers that don't exist in this repo. Grepping every .mcp.json, the names capiq, internal-gl, subledger, screening, crm, nav, and portfolio are defined nowhere, yet they appear in the tools: frontmatter of eight agents under plugins/agent-plugins/. Previously reported as part 2 of Three install/runtime bugs: invalid hooks.json, mcp__capiq__* allowlist mismatch, and stale README install path #131.
  • No agent grants the Skill tool. All ten agent definitions carry a "Skills this agent uses" section, but none list Skill in tools:, so those skills can't be invoked. Relatedly, none list Bash, which xlsx-author and pptx-author require ("Write a short Python script and run it with Bash").

Happy to send follow-up PRs for either if you can confirm the intended tool policy.

🤖 Generated with Claude Code

The mcpServers block is missing a comma after the "egnyte" entry and
never closes the "box" object, so the file fails to parse and none of
the 12 MCP servers declared by this plugin load.

    $ python -c "import json; json.load(open('.mcp.json'))"
    json.decoder.JSONDecodeError: Expecting ',' delimiter: line 47 column 5

Adds the missing comma and the missing closing brace. No server
definitions are added, removed, or changed. After the fix all 12
servers parse: daloopa, morningstar, sp-global, factset, moodys,
mtnewswire, aiera, lseg, pitchbook, chronograph, egnyte, box.

Fixes anthropics#264
Fixes anthropics#273
Fixes anthropics#292

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant