feat(sandbox): support more options in customConfig for wrapWithSandbox - #420
Open
gpanders wants to merge 1 commit into
Open
feat(sandbox): support more options in customConfig for wrapWithSandbox#420gpanders wants to merge 1 commit into
gpanders wants to merge 1 commit into
Conversation
gpanders
force-pushed
the
push-yxnoqppnpsws
branch
from
July 27, 2026 17:22
8ef3ab4 to
a806eb7
Compare
gpanders
force-pushed
the
push-yxnoqppnpsws
branch
4 times, most recently
from
August 11, 2026 19:36
b9fed1d to
ca646c3
Compare
jonathanKingston
added a commit
to copse-dev/agent-pane
that referenced
this pull request
Sep 7, 2026
## Summary - add an explicit, off-by-default macOS permission for Copse's native `git_commit` subprocess to reach the single Unix socket named by `SSH_AUTH_SOCK` - preserve the existing filesystem and internet-deny sandbox, and replace path-configured SSH signing keys with an inline public identity so the private key and `.ssh` directory remain unreadable - pin a one-line sandbox-runtime patch so the documented per-spawn `allowUnixSockets` override reaches the macOS seatbelt profile - explain the Git-hook/agent capability boundary in Settings and the shell-permissions documentation Closes [#2320](#2320). The dependency patch can be removed after [anthropics/sandbox-runtime#420](anthropics/sandbox-runtime#420) ships in a release. ## Security boundary The grant is macOS-only, requires explicit user consent, validates that `SSH_AUTH_SOCK` is an absolute normalized socket, and applies only to the native commit spawn. Network domains remain denied. Git hooks inherit the commit process and can ask ssh-agent to use any loaded key, so the UI recommends `ssh-add -c`. ## Validation - `pnpm test -- git-commit-signing` — 12 passed - `pnpm test` — 8,555 passed - `pnpm run typecheck` - `pnpm run lint` - `pnpm run format:check` - `pnpm run check:dead-code` - `pnpm run check:oracle` - `pnpm run check:e2e-syntax` - `pnpm run demo:site:check` - `pnpm run build` - `pnpm install --frozen-lockfile --ignore-scripts` - focused Electron e2e: 2 passed - `git diff --check` ## Visual evidence  Co-Authored-By: Copse <noreply@copse.dev> Copse-Models: acp:codex-acp#gpt-5.6-sol, acp:claude-acp#opus[1m] --------- Co-authored-by: Copse <noreply@copse.dev> Co-authored-by: copse-release-bot[bot] <304038887+copse-release-bot[bot]@users.noreply.github.com> Co-authored-by: jonathanKingston <338988+jonathanKingston@users.noreply.github.com>
The customConfig parameter of wrapWithSandbox accepts more options than are actually forwarded to the underlying sandbox. For instance, `allowUnixSockets`, `enableWeakerNetworkIsolation`, and `allowAppleEvents` can be set in `customConfig` today, but it has no effect on `wrapWithSandbox` because those fields are ignored. This commit reads those values from `customConfig` when creatin the sandbox, falling back to the default value if unspecified.
gpanders
force-pushed
the
push-yxnoqppnpsws
branch
from
September 9, 2026 20:13
ca646c3 to
0e6776a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The customConfig parameter of wrapWithSandbox accepts more options than are actually forwarded to the underlying sandbox. For instance,
allowUnixSockets,enableWeakerNetworkIsolation, andallowAppleEventscan be set incustomConfigtoday, but it has no effect onwrapWithSandboxbecause those fields are ignored.This commit reads those values from
customConfigwhen creatin the sandbox, falling back to the default value if unspecified.