Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Phase 4 of the system-catalog docs data migration.
Stacked on phase 3 (base branch
catalog-docs-data-phase3).Description
Acknowledges the 19
mz_introspection_rawrelations (internal differential-dataflow logging inputs) asrawvariants on their parent's YAML entry, removing theirRELATION_SPEC_UNDOCUMENTEDmarkers.A raw variant is name-plus-kind only, with no column table; the shortcode groups a relation's raw siblings into one "Raw relations" warning section (for example the nine raw inputs under
mz_arrangement_sizes).Lint treats raw variants as existence-only, so this is a pure move: the generated
test/sqllogictest/autogenerated/mz_introspection.sltis unchanged.Each raw relation's parent is the documented section it sits under in the markdown, resolved with a generator that resets attribution at the reference-link-definition block so the trailing orphan cluster is not misattributed.
mz_dataflow_operator_reachability(and its per-worker/raw siblings) and two orphan per-worker relations whose parents live inmz_internalstay asRELATION_SPEC_UNDOCUMENTED, pending phase 5 and subject-matter input.Verification
ci/test/lint-docs-catalog.shreports zero diff (pure-move proof),bin/sqllogictestpasses, and the two-buildhugo+htmltestgate is clean (895 documents, 0 errors). The generator has unit tests (ci/test/test_gen_raw_variants.py).