fix(select): replace unsafe transmute_copy with safe Any downcasting in confirm prompt#2794
Merged
tusharmath merged 2 commits intomainfrom Apr 2, 2026
Merged
fix(select): replace unsafe transmute_copy with safe Any downcasting in confirm prompt#2794tusharmath merged 2 commits intomainfrom
tusharmath merged 2 commits intomainfrom
Conversation
Collaborator
Author
|
fixes #2766 |
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
unsafe { std::mem::transmute_copy }in the fzf confirmation prompt with safeAny-based downcasting to eliminate undefined behavior that could cause a segmentation fault.Context
A segmentation fault (
zsh: segmentation fault forge) was observed after forge starts and displays the fzf model selection popup. Investigation traced the issue to the onlyunsafeblock inforge_select, introduced in #2546 whendialoguerwas replaced withfzf-wrapped.The
prompt_confirmfunction usedtransmute_copyto convert aboolvalue into a generic typeT. While a runtimeTypeIdguard ensuredT == boolbefore the call,transmute_copyis inherently unsound here because it readssize_of::<T>()bytes from a 1-byteboolon the stack. If the compiler monomorphizes the function for anyTlarger thanbool(e.g.ModelRow), the generated code body contains a stack buffer over-read, which is undefined behavior regardless of whether that code path executes at runtime.Changes
prompt_confirm<T>into two functions:prompt_confirm-- returnsResult<Option<bool>>directly, no generics, nounsafeprompt_confirm_as<T>-- safe wrapper that converts theboolresult intoTviaBox<dyn Any>::downcast::<T>()SelectBuilder::promptto useprompt_confirm_asTesting
cargo test -p forge_selectAll 14 existing tests pass. The change is a pure refactor of internal functions with no public API change -- any code that previously called
ForgeWidget::select,ForgeWidget::confirm, or theSelectBuilder<bool>path continues to work identically.