Fix: Sanitize HTML error responses in request() to improve Sentry reporting#122
Open
Fix: Sanitize HTML error responses in request() to improve Sentry reporting#122
Conversation
…orting When the API returns a non-OK response with an HTML body (e.g. a 404 page), the entire HTML gets stuffed into the Error message. This causes Sentry to misparse stacktraces and breaks error grouping. Now we detect HTML responses (via DOCTYPE/html prefix or content-type header) and extract just the <title> text, falling back to 'HTML error page'. Plain text errors are truncated to 200 chars. The full raw error (up to 500 chars) is still logged to console for debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the API returns a non-OK response with an HTML body (e.g. a 404 "Page not found" page), the entire HTML gets stuffed into the
Errormessage. This causes:Sentry issue: https://gumroad-to.sentry.io/issues/7369975611/
Solution
Detect HTML error responses via:
<!DOCTYPEor<htmlprefix in the response bodytext/htmlin theContent-TypeheaderWhen HTML is detected, extract just the
<title>text (e.g. "Page not found"), falling back to "HTML error page". Plain-text errors are truncated to 200 chars for cleaner Sentry reporting.The full raw error body (up to 500 chars) is still logged to
console.infofor debugging.Tests
Added 6 tests covering: success path, 401, plain-text truncation, HTML title extraction, HTML without title fallback, and content-type detection.