Fix unhandled rejection when Linking.openURL fails for embed URLs#129
Open
Fix unhandled rejection when Linking.openURL fails for embed URLs#129
Conversation
When WebView content contains iframely embeds (e.g. YouTube), the navigation intercept calls Linking.openURL which throws if the system can't open the URL as a native deep link. Add .catch() fallback to open such URLs in an in-app browser via expo-web-browser instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.catch()fallback onLinking.openURL()calls inapp/purchase/[token].tsxandapp/post/[id].tsxLinking.openURLfails (e.g. for iframely embed URLs that can't be opened as native deep links), falls back toWebBrowser.openBrowserAsync()to open the URL in an in-app browsercdn.iframe.lyembed URLsTest plan
Linking.openURL🤖 Generated with Claude Code