Skip to content

Fix IllegalStateException: Already closed in PDF viewer #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gumclaw wants to merge 2 commits into
base: main
Choose a base branch
from
+33 −22
Open

Fix IllegalStateException: Already closed in PDF viewer #142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5396352
Fix IllegalStateException: Already closed in PDF viewer
gumclaw Apr 1, 2026
dd3546e
[autofix.ci] apply automated fixes
autofix-ci[bot] Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 33 additions & 22 deletions app/pdf-viewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,15 @@ export default function PdfViewerScreen() {
const [showTocModal, setShowTocModal] = useState(false);
const [showViewModeModal, setShowViewModeModal] = useState(false);
const [isSharing, setIsSharing] = useState(false);
const [pdfMounted, setPdfMounted] = useState(true);

const switchViewMode = (mode: "single" | "continuous") => {
// Unmount the PDF component first to let the native rendering thread finish
// before the document is closed, avoiding IllegalStateException: Already closed
setPdfMounted(false);
setViewMode(mode);
requestAnimationFrame(() => setPdfMounted(true));
};

useEffect(() => {
if (Platform.OS === "android") {
Expand Down Expand Up @@ -127,26 +136,28 @@ export default function PdfViewerScreen() {
),
}}
/>
<Pdf
key={viewMode}
ref={pdfRef}
source={{ uri }}
style={styles.pdf}
trustAllCerts={false}
fitPolicy={0}
enablePaging={viewMode === "single"}
horizontal={viewMode === "single"}
page={initialPage ? Number(initialPage) : 1}
onLoadComplete={(numberOfPages, _path, _size, toc) => {
setTotalPages(numberOfPages);
setTableOfContents(toc ?? []);
}}
onPageChanged={(page) => setCurrentPage(page)}
onError={(error) => {
Sentry.captureException(error);
console.error("PDF Error:", error);
}}
/>
{pdfMounted && (
<Pdf
key={viewMode}
ref={pdfRef}
source={{ uri }}
style={styles.pdf}
trustAllCerts={false}
fitPolicy={0}
enablePaging={viewMode === "single"}
horizontal={viewMode === "single"}
page={initialPage ? Number(initialPage) : 1}
onLoadComplete={(numberOfPages, _path, _size, toc) => {
setTotalPages(numberOfPages);
setTableOfContents(toc ?? []);
}}
onPageChanged={(page) => setCurrentPage(page)}
onError={(error) => {
Sentry.captureException(error);
console.error("PDF Error:", error);
}}
/>
)}

<Sheet open={showTocModal} onOpenChange={setShowTocModal}>
<SheetHeader onClose={() => setShowTocModal(false)}>
Expand Down Expand Up @@ -181,7 +192,7 @@ export default function PdfViewerScreen() {
<SheetContent className="p-4">
<TouchableOpacity
onPress={() => {
setViewMode("single");
switchViewMode("single");
setShowViewModeModal(false);
}}
className="flex-row items-center justify-between border-b border-border py-4"
Expand All @@ -194,7 +205,7 @@ export default function PdfViewerScreen() {
</TouchableOpacity>
<TouchableOpacity
onPress={() => {
setViewMode("continuous");
switchViewMode("continuous");
setShowViewModeModal(false);
}}
className="flex-row items-center justify-between border-b border-border py-4"
Expand Down
Loading