fix(TypeScript): update and add missing definition in IntervalSEt.d.ts #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eury.tang <[email protected]>
|
Instead of fixing each problem in the standard TS runtime step by step you could use a really complete TS runtime, which is also faster (antlr4ng). Saves you some headache. |
Thanks for the recommendation, I'll check it out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the TypeScript target, I noticed that the IntervalSet.d.ts file didn't match the code in IntervalSet.js—they really should be the same. Because of this mismatch, I ran into the error TS2339: "Property 'addRange' does not exist on type 'IntervalSet'" when I tried to use IntervalSet utilities like addOne. So, in this PR, I've made changes to ensure they are consistent.