[build] Update to version 0.23.16 of Trash Toolkit. #4425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to update to 0.23.16 and skip 0.23.15. |
kaby76
changed the title
All ports need to be rewritten in target agnostic format.
|
The antlr/antlr4 grammar was broken quite a bit, but the tester did not test it properly before committing the PR. Will remove all the broken ports, remaster the tests. Will need to redo the ports in target agnostic format later. |
…ntlr-ng generator for Antlr4ng testing.
|
@kaby76 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build is mainly to fix one issue: #4434 This PR updates the Trash Toolkit to the latest available, version 0.23.16. In doing so, it also includes a couple of new features. One is related to the discussion on maintaining the PT MySQL. It also updates the build to include the new Antlr-ng generator because that is required for testing the Antlr4ng runtime. The runtime no longer wraps the old Java parser generator in the runtime.
The update fixes several problems with the grammar dependency analysis in trgen, which caused testing for #4424 to report "success" when it really failed; It should have warned that the changes to antlr/antlr4 contained errors, e.g., the use of "this" in the Python3 fork of the grammar, and the parse .errors file for three.g4 needed to be remastered.
Trgen works for all of grammars-v4, except for sql/hive/v3. It turns out that that grammar is invalid: #4428
In addition, this PR adds "cross-import grammar" testing. By that, one can write a grammar in one directory that uses Antlr
importstatements to override another grammar. To illustrate and test this capability, I added the trapc grammar. master...kaby76:grammars-v4:g4-4430