Skip to content

Conversation

@kaby76
Copy link
Contributor

@kaby76 kaby76 commented Jul 23, 2025

Please merge #4570 first.

This is a fix for #4555. With this PR, the Maven tester is once again checked. While it misses many features that the trgen tester does, the Maven tester still is a good, quick check, and people seem to prefer that.

This PR changes:

  • Github workflows file main.yml. The job "maven" has been added. It computes the before and after Git SHA's for a PR, then calls a new script, maven.sh.
  • _scripts/maven.sh: This Bash script computes the directories changed in a PR, then processes them with the Maven tester. We don't do a full repo test.
  • At the end of the grammar tests, mvn clean is done at the root for a quick sanity check of the root pom.xml.

Some of the grammars had problems in their pom.xml: bison, clif, ocl, pike, ruleworks, spl, teal, tinyos_nesc. These were corrected in various ways.

@teverett
Copy link
Member

teverett commented Aug 6, 2025

@kaby76 thanks

@teverett teverett merged commit e56b92d into antlr:master Aug 6, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants