#22: Warning about X11

antroids · Mar 22, 2024 · 9dbe37d · 9dbe37d
1 parent 3238abf
commit 9dbe37d
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 1 deletion.
diff --git a/package/contents/ui/ActiveTasksModel.qml b/package/contents/ui/ActiveTasksModel.qml
@@ -69,6 +69,7 @@ TaskManager.TasksModel {
     onCountChanged: updateActiveTaskIndex()
     sortMode: TaskManager.TasksModel.SortLastActivated
     groupMode: TaskManager.TasksModel.GroupDisabled
+    Component.onCompleted: updateActiveTaskIndex()
 
     virtualDesktopInfo: TaskManager.VirtualDesktopInfo {
     }

diff --git a/package/contents/ui/config/ConfigBehavior.qml b/package/contents/ui/config/ConfigBehavior.qml
@@ -58,6 +58,14 @@ KCM.SimpleKCM {
             }
         }
 
+        Kirigami.InlineMessage {
+            anchors.left: parent.left
+            anchors.right: parent.right
+            text: i18n("Some functionality is unsupported or can work unstable in X11 sessions.")
+            type: Kirigami.MessageType.Error
+            visible: !Utils.isWayland()
+        }
+
         RowLayout {
             Kirigami.FormData.label: i18n("Active task source:")
 
@@ -141,14 +149,34 @@ KCM.SimpleKCM {
             to: 512
         }
 
+        Kirigami.InlineMessage {
+            anchors.left: parent.left
+            anchors.right: parent.right
+            text: i18n("Window Move action is incompatible with Mouse Drag in X11 sessions.")
+            type: Kirigami.MessageType.Error
+            visible: !Utils.isWayland() && leftButtonDragAction.currentValue == "Window Move"
+        }
+
         KWinShortcutComboBox {
+            id: leftButtonDragAction
+
             label: i18n("Left button drag:")
             enabled: windowTitleDragEnabled.checked
             initialValue: cfg_widgetMouseAreaLeftDragAction
             onActivated: cfg_widgetMouseAreaLeftDragAction = currentValue
         }
 
+        Kirigami.InlineMessage {
+            anchors.left: parent.left
+            anchors.right: parent.right
+            text: i18n("Window Move action is incompatible with Mouse Drag in X11 sessions.")
+            type: Kirigami.MessageType.Error
+            visible: !Utils.isWayland() && middleButtonDragAction.currentValue == "Window Move"
+        }
+
         KWinShortcutComboBox {
+            id: middleButtonDragAction
+
             label: i18n("Middle button drag:")
             enabled: windowTitleDragEnabled.checked
             initialValue: cfg_widgetMouseAreaMiddleDragAction

diff --git a/package/contents/ui/utils.js b/package/contents/ui/utils.js
@@ -4,6 +4,10 @@
  * SPDX-License-Identifier: GPL-3.0-or-later
  */
 
+function isWayland() {
+    const isWaylandPlugin = Qt.platform.pluginName == "wayland";
+    return isWaylandPlugin;
+}
 
 function copyLayoutConstraint(from, to) {
     Object.assign(to.Layout, {

diff --git a/package/metadata.json b/package/metadata.json
@@ -12,7 +12,7 @@
         "Id": "com.github.antroids.application-title-bar",
         "Name": "Application Title Bar",
         "License": "GPL-3.0+",
-        "Version": "0.4.2",
+        "Version": "0.4.3",
         "Website": "https://github.com/antroids/application-title-bar",
         "FormFactors": [
             "desktop"