Skip to content

Conversation

@hustcc
Copy link
Member

@hustcc hustcc commented Nov 4, 2025

PR includes

  • flatten the mono repo packages

@hustcc hustcc changed the base branch from master to v4 November 4, 2025 09:14
@gemini-code-assist
Copy link

Summary of Changes

Hello @hustcc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring effort to flatten the project's monorepo structure. By consolidating previously distinct packages into a single root-level entity, the aim is to streamline development workflows, simplify build processes, and centralize configuration management. This change impacts various aspects of the codebase, from build and test configurations to module imports and project documentation, ultimately leading to a more cohesive and manageable project.

Highlights

  • Monorepo Flattening: The project structure has been flattened, consolidating previously separate packages like @antv/ava and @antv/ava-react into a single root-level package. This simplifies the overall architecture and management.
  • Build and Configuration Streamlining: Build configurations (.fatherrc.ts, package.json), linting rules (.eslintrc.js, .eslintignore), and testing setups (jest.config.js) have been updated and centralized to support the new unified package structure. This includes removing Lerna and semantic-release configurations.
  • Codebase Restructuring: Numerous test files and source code modules have been relocated from their original packages/ava and packages/ava-react directories to a new, flattened __tests__ and src directory at the repository root. Import paths have been updated to reflect these changes, utilizing @ava/ aliases.
  • Removal of @antv/ava-react: The entire @antv/ava-react package, including its source code, configurations, and documentation, has been removed. This indicates a strategic decision regarding the future of these React components, possibly integrating them directly into @antv/ava or deprecating them.
  • Documentation Updates: The Chinese README.zh-CN.md and CONTRIBUTING.zh-CN.md files have been revised to accurately reflect the new project structure, removed packages, and updated contribution guidelines.
Ignored Files
  • Ignored by pattern: .github/workflows/** (5)
    • .github/workflows/auto-release.yml
    • .github/workflows/build.yml
    • .github/workflows/mirror.yml
    • .github/workflows/release-notify.yml
    • .github/workflows/sync-after-auto-release.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request flattens the monorepo structure into a single package, which is a significant refactoring. The changes in configuration files like package.json, jest.config.js, and tsconfig.json reflect this move. However, I've found several critical and high-severity issues in the new configuration that will likely prevent the project from building or testing correctly. These include a self-reference in jest.config.js, an incomplete module alias mapping for Jest, a major downgrade of the TypeScript version, and some questionable dependency versions in package.json. There's also a minor redundancy in the .fatherrc.ts aliases. Addressing these issues should be a priority to ensure the flattened repository is functional.

@hustcc hustcc merged commit a0d5696 into v4 Nov 5, 2025
1 check failed
@hustcc hustcc deleted the flatten-packages branch November 5, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants