-
Notifications
You must be signed in to change notification settings - Fork 148
flatten the mono repo packages #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @hustcc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring effort to flatten the project's monorepo structure. By consolidating previously distinct packages into a single root-level entity, the aim is to streamline development workflows, simplify build processes, and centralize configuration management. This change impacts various aspects of the codebase, from build and test configurations to module imports and project documentation, ultimately leading to a more cohesive and manageable project. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request flattens the monorepo structure into a single package, which is a significant refactoring. The changes in configuration files like package.json, jest.config.js, and tsconfig.json reflect this move. However, I've found several critical and high-severity issues in the new configuration that will likely prevent the project from building or testing correctly. These include a self-reference in jest.config.js, an incomplete module alias mapping for Jest, a major downgrade of the TypeScript version, and some questionable dependency versions in package.json. There's also a minor redundancy in the .fatherrc.ts aliases. Addressing these issues should be a priority to ensure the flattened repository is functional.
PR includes