Skip to content

Conversation

@linkun-wang
Copy link
Contributor

@linkun-wang linkun-wang commented Nov 5, 2025

Description

Close #4869 :解决连线vertices工具removeRedundancies设置为false时,拖动连线无法加入历史队列、mouseup事件无法冒泡到连线的问题;补充了examples中历史队列&连线vertices工具共同使用的示例场景

Motivation and Context

#4869 :1.x版本中的连线vertices工具,如果配置removeRedundancies为false,则拖动路径点改变连线走向无法加入历史队列;且mouseup事件无法冒泡到连线上(即使设置了stopPropagation为false)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@linkun-wang linkun-wang marked this pull request as ready for review November 6, 2025 08:53
@linkun-wang linkun-wang marked this pull request as draft November 6, 2025 08:57
@linkun-wang linkun-wang marked this pull request as ready for review November 6, 2025 09:36
@linkun-wang
Copy link
Contributor Author

@NewByVector @lxfu1 大佬帮忙看下check流水线的问题,看起来有些报错需要项目管理员才能解决

@hustcc
Copy link
Member

hustcc commented Nov 11, 2025

这还是 v1 的代码,勇士啊,来看看 master 上有类似的问题吗?

@linkun-wang
Copy link
Contributor Author

这还是 v1 的代码,勇士啊,来看看 master 上有类似的问题吗?

看了下master的代码,应该没有历史队列的问题,但是removeRedundancies为false时,mouseup无法冒泡到edge的问题应该还是存在的。这两天我抽空在本地跑下master的代码再提个pr吧。话说v1的不管了吗?😔😅

@linkun-wang linkun-wang changed the title fix: 🐛 解决连线vertices工具removeRedundancies设置为false时,拖动连线无法加入历史队列、mouseup事件无法冒泡到连线的问题 fix: 🐛 解决v1版本中连线vertices工具removeRedundancies设置为false时,拖动连线无法加入历史队列、mouseup事件无法冒泡到连线的问题 Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants