Let media have a different bucket if desired #1
Conversation
This gives priority to 'MEDIA_'-prefixed settings keys so we can define a media-specific bucket if necessary. The default key names remain the same so this should be a drop-in replacement.
|
Hi @anush0247, can you have a look at my pull request please? |
|
Upstream is not responding so I will push a fork on pypi (zappa-file-widget-mediabucket), hopefully only temporarily |
|
The forked package can be found at https://pypi.python.org/pypi/zappa-file-widget-mediabucket |
|
@rebost did you check my commit review comments? |
|
@anush0247 I have looked everywhere I could think of and have not seen your review comments. Could you please provide a link? |
| s3_host_from_settings = getattr(settings, 'MEDIA_AWS_S3_HOST', 'AWS_S3_HOST') | ||
| s3_host = s3_host_from_settings or 's3-ap-southeast-1.amazonaws.com' | ||
| default_region = s3_host.split(".amazonaws.com")[0].split("s3-")[1] | ||
| aws_storage_bucket_name = getattr(settings, 'MEDIA_AWS_STORAGE_BUCKET_NAME', 'AWS_STORAGE_BUCKET_NAME') |
There was a problem hiding this comment.
I appreciate your concept of having separate media bucket name. But consider
AWS_STORAGE_BUCKET_NAME this is going to be the default value if no MEDIA_AWS_STORAGE_BUCKET_NAME defined in the settings.
My Concern is to provide backward compatibility.
There was a problem hiding this comment.
Excuse me if I do not understand your comment correctly: the proposed changes are meant to provide full backwards compatibility. Unless settings.MEDIA_xxx is provided the exact same settings.xxx your code uses is used for xxx. One example (the other two context keys behave in the exact same way):
-
branch master:
context['AWS_ACCESS_KEY_ID'] == settings.AWS_ACCESS_KEY_ID -
branch feature/allow_media_differentiation, with settings.MEDIA_AWS_ACCESS_KEY_ID not defined:
context['AWS_ACCESS_KEY_ID'] == settings.AWS_ACCESS_KEY_ID -
branch feature/allow_media_differentiation, with settings.MEDIA_AWS_ACCESS_KEY_ID defined:
context['AWS_ACCESS_KEY_ID'] == settings.MEDIA_AWS_ACCESS_KEY_ID
case 2) defaults back to the same values as case 1) so someone upgrading to the new version of zappa-file-widget and not modifying his settings would see no difference.
|
@anush0247 , please see my reply from May 6th |
This gives priority to 'MEDIA_'-prefixed settings keys so we can
define a media-specific bucket if necessary. The default key names
remain the same so this should be a drop-in replacement.