New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close iframe/modal only on signerComplete and signerError #31

Merged

patapat merged 1 commit into master from pl/handle-sign-iframe-events

Mar 25, 2024

Contributor

patapat commented Mar 22, 2024

iframe and modal were previously closing on all signer events, but with the recently added signerLoad event, it was closing right away.

Correctly stays open on signerLoad

Completes and closes on signerComplete


          Close frame/modal only on signerComplete and signerError

3afeda6

patapat requested a review from benogle

March 22, 2024 17:56

benogle approved these changes

View reviewed changes

patapat merged commit 0e0e174 into master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment