Workaround for postmark inbound test email can not be parsed #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Therry van Neerven <[email protected]>
Signed-off-by: Therry van Neerven <[email protected]>
Ecno92
force-pushed
the
issue-304-Postmark-inbound-test-email-can-not-be-parsed
branch
from
953d44b
to
43e6715
Compare
|
This looks great. Thanks! (The test failures on Python 3.6 aren't related to this PR. They're also failing in the weekly test run, so something outside Anymail has changed.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we discussed the issue that Postmark's inbound test webhooks are not in the same format as real inbound webhooks.
I have created a workaround for this issue. Now anymail will handle the events without crashing.
Also it will raise a warning, so that the user might consider testing with a real event before going to production.
I did my best to make this change according to the quality standards of this project. If something is missing or changed let me know.
Closes #304