Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-4588 layout resolver #1975

Open
wants to merge 23 commits into
base: feature/primitives
Choose a base branch
from
Open

Conversation

KirillSto
Copy link
Member

@KirillSto KirillSto commented Dec 21, 2024

https://linear.app/anytype/issue/GO-4588/add-resolvedlayout-resolver-to-middle-side

  • substitute all occurences of layout with resolvedLayout
  • on sb.Apply for type objects if recommendedLayout is changed ->
    • query all objects of this type from store
    • rm layout and set resolvedLayout
    • set recommendedLayout
  • if change is recieved (StateAppend) same scenario should be held, except layout deletion from objects
  • on sb.Apply of every object resolvedLayout should be derived from type or from layout detail
  • remove WithLayout template
  • make Task, Page and Note editable

@KirillSto KirillSto self-assigned this Dec 21, 2024
@KirillSto KirillSto changed the base branch from main to feature/primitives December 21, 2024 10:27
Copy link

github-actions bot commented Jan 7, 2025

New Coverage 50.6% of statements
Patch Coverage 64.0% of changed statements (291/455)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@KirillSto KirillSto marked this pull request as ready for review January 7, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant