Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-4810: Make notifications optional in progress bar #1996

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AnastasiaShemyakinskaya
Copy link
Member

  1. Add new param in export request noProgress - to turn off progress and notification events.
  2. Move logic of sending notifications from export service to queue service - I implemented existing interfaces Notificationable and NotificationSender (NotificationSender is used in processes service to send notifications)
  3. Remove queue.Stop() call as it doesn't do anything

… notifications events

Signed-off-by: AnastasiaShemyakinskaya <[email protected]>
Copy link

github-actions bot commented Jan 8, 2025

New Coverage 50.5% of statements
Patch Coverage 63.5% of changed statements (33/52)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

Signed-off-by: AnastasiaShemyakinskaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant