Fix select network and add token requests #11
Conversation
If ethereum provider is a class, spreading it onto a new object won't copy methods to the new object
|
I've tested this fix locally and switching networks via the AnySwap UI works as expected with the injected provider from our wallet, and still works as expected with MetaMask. |
src/config/tools/methods.ts
Outdated
| const ethereumFN: any = ethereum; | ||
| ethereumFN.request = (ethereum as any).request ?? ''; |
There was a problem hiding this comment.
calling ethereumFN.request will throw an error if ethereum obj is undefined. You dont need to set the request method as it should be part of the ethereum object you are referencing
| const ethereumFN: any = ethereum; | |
| ethereumFN.request = (ethereum as any).request ?? ''; | |
| const ethereumFN: any = ethereum |
There was a problem hiding this comment.
Yeah, this is definitely better. I originally raised an issue (#10) about this, I'm not sure why the code is de-structuring ethereumFN from window.ethereum at all, but I tried to keep my PR as close to the original code as possible. But I should have made lines 9 & 10 like this to properly maintain consistency:
const ethereumFN: any = ethereum ?? {};
ethereumFN.request = (ethereum as any).request ?? '';
There was a problem hiding this comment.
I simplified the code in my PR slightly which should also fix the concern with window.ethereum being undefined.
src/config/tools/methods.ts
Outdated
| const ethereumFN: any = ethereum; | ||
| ethereumFN.request = (ethereum as any).request ?? ''; |
There was a problem hiding this comment.
ditto
| const ethereumFN: any = ethereum; | |
| ethereumFN.request = (ethereum as any).request ?? ''; | |
| const ethereumFN: any = ethereum |
If Ethereum provider is a class, spreading it onto a new object won't copy methods to the new object
Fixes #10