-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of puppy store #679
Conversation
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 288 288
Lines 5967 5967
=====================================
Hits 5967 5967
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, less than I usually make. Some things I commented on occurs multiple times and I did not comment on each occurrence, so do check the rest of the code to apply the same comments elsewhere.
…p and sync.map Implementation of sync map using mutex and testing using TestMain Use testify suite instead of test main Updated to use sync.map as per instructions fixed formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. You know what you're doing here, so i'll approve for merging. You can choose to address the comments or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CRUD interface and storage using map and sync.map
Fixes #680
Review of colleague's PR #605 and #533
Changes proposed in this PR:
Implementation of the puppy CRUD interface and storing it in map and sync.map
-