v2.1: Extract solana-nonce crate (backport of #3082)#3370
Closed
mergify[bot] wants to merge 2 commits intov2.1from
Closed
v2.1: Extract solana-nonce crate (backport of #3082)#3370mergify[bot] wants to merge 2 commits intov2.1from
mergify[bot] wants to merge 2 commits intov2.1from
Conversation
* extract solana-nonce crate * activate solana-nonce/serde in solana-program * update lock file * post-rebase fixes * add docsrs metadata Co-authored-by: Jon C <me@jonc.dev> * add doc_auto_cfg * reorganise modules --------- Co-authored-by: Jon C <me@jonc.dev> (cherry picked from commit 1cde3d5) # Conflicts: # Cargo.toml
Author
|
Cherry-pick of 1cde3d5 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
master pr appears to be missing deprecation warnings. commented there |
joncinque
added a commit
to joncinque/agave
that referenced
this pull request
Nov 5, 2024
#### Problem As pointed out at anza-xyz#3370 (comment), the solana-nonce crate re-export in solana-program does not have a deprecated warning. #### Summary of changes Add the warning.
|
Gonna close this one -- it'll just force us to move the sdk into a new repo faster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
solana_program::nonceimposes asolana_programdependency onsolana_svmSummary of Changes
This branches off #2969 so that needs to be merged first
This is an automatic backport of pull request #3082 done by [Mergify](https://mergify.com).