Fix violations of elided_named_lifetimes #3449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bw-solana
reviewed
Nov 4, 2024
bw-solana
left a comment
bw-solana
left a comment
There was a problem hiding this comment.
Looks like there are some conflicts that will need to be resolved, but this LGTM
rust-lang/rust#129207 helps name certain elided lifetimes
bw-solana
approved these changes
Nov 6, 2024
|
@ksolana looks like you checked in file |
Author
|
ah, sorry about that. putting a patch to remove that file. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
rust-lang/rust#129207 helps name certain elided lifetimes so we can name them accordingly.
Summary of Changes
Add lifetime markers for those reported by the linter