accounts-db: Improve hashing of the read-only cache #4300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR can live on its own. IOW, rebase on master and we can get it in as-is without needing to wait for #3943. |
vadorovsky
force-pushed
the
ro-cache-hash
branch
from
377fbcd to
54507a5
Compare
brooksprumo
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Please wait for approval from @alessandrod too before merging.
Oh, maybe this my computer showing me suggested reviewers, and I jumped the gun here.
|
Also, we need #4303 to unblock the CI |
`DashMap` uses SipHash by default. Change it to AHash, which is more lightweight. Ref anza-xyz#4276
vadorovsky
force-pushed
the
ro-cache-hash
branch
from
54507a5 to
4628220
Compare
alessandrod
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DashMapuses SipHash by default.Summary of Changes
Change it to AHash, which is more lightweight.
Ref #4276