Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add feature revoke #4361

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

buffalojoec
Copy link

@buffalojoec buffalojoec commented Jan 9, 2025

Problem

The new Feature Gate Core BPF program is live at Feature111111... on both testnet and devnet, and will soon be on mainnet-beta.

With this new program, we can revoke features that are pending activation. The program has only one instruction, RevokePendingActivation, which simply "closes" a newly created feature account by:

  • Deallocating its data
  • Burning its lamports
  • Reassigning it to System

However, core contributors who wish to use this new capability have no way of doing so from the CLI.

Summary of Changes

Add a new command to the solana feature CLI that invokes the RevokePendingActivation instruction on the Feature Gate program to revoke a pending activation.

For more information about this instruction, see the program's instruction source. However, in summary, once a feature is activated with solana feature activate, it can be revoked at any time before the epoch rollover, while the state is still zeroed. Once the epoch concludes and the feature is activated by the runtime, the account is bestowed with valid Feature state and thus can no longer be revoked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant