Uses file io as default method to access account storages #4365
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
reviewed
Jan 9, 2025
| /// ancient storages are created by 1-shot write to pack multiple accounts together more efficiently with new formats | ||
| #[default] |
There was a problem hiding this comment.
yuck. config defaults like this should be made in the cli config, not pervade the codebase
brooksprumo
force-pushed
the
file-io/default
branch
from
99c5180 to
6f76949
Compare
brooksprumo
requested review from
alessandrod,
HaoranYi,
t-nelson and
jeffwashington
HaoranYi
approved these changes
Jan 10, 2025
t-nelson
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Account storages can be accessed via mmap or file io. The default is mmap, but @alessandrod has used his profiler to show this is bad for performance.
Summary of Changes
Set the default account storage access method to be file io. Node operators can still opt back to mmaps with
--accounts-db-access-storages-method mmap.The file io impl has been in the validator for many releases and has been running on various canaries/dev boxes/pop-net clusters for a while. I haven't observed any correctness issues. My metrics show replay perf isn't degraded. Alessandro may be able to add more details from profiler results as well.