Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use solana-account instead of solana-sdk in solana-stake-program #4374

Merged
merged 1 commit into from
Jan 13, 2025
Merged

use solana-account instead of solana-sdk in solana-stake-program #4374

merged 1 commit into from
Jan 13, 2025

Conversation

kevinheavey
Copy link

Same idea as #4327

@kevinheavey kevinheavey changed the title use solana-account instead of solana-sdk in solana-program use solana-account instead of solana-sdk in solana-stake-program Jan 10, 2025
@mergify Mergify
Copy link

mergify bot commented Jan 10, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@kevinheavey kevinheavey force-pushed the stake-program-replace-sdk-account branch 2 times, most recently from 81ad934 to 5199dd8 Compare January 10, 2025 13:48
@kevinheavey kevinheavey force-pushed the stake-program-replace-sdk-account branch from 5199dd8 to dee707c Compare January 10, 2025 16:11
tao-stones
tao-stones approved these changes Jan 13, 2025
View reviewed changes
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Jan 13, 2025
@mergify mergify bot merged commit c13ab9c into anza-xyz:master Jan 13, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones approved these changes

Assignees
No one assigned
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinheavey @tao-stones