Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce public visibility of some SVM related structs and APIs #4378

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Reduce public visibility of some SVM related structs and APIs #4378

merged 2 commits into from
Jan 10, 2025
+14 −6

Conversation

pgarg66
Copy link

@pgarg66 pgarg66 commented Jan 10, 2025

Problem

Some structs and APIs in builtin-default-costs, and compute-budget can have reduced public visibilty.

Summary of Changes

Change the visibility to private or pub(crate).

Fixes #

@pgarg66 pgarg66 marked this pull request as ready for review January 10, 2025 17:55
@pgarg66 pgarg66 requested review from a team as code owners January 10, 2025 17:55
tao-stones
tao-stones approved these changes Jan 10, 2025
View reviewed changes
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pgarg66 pgarg66 merged commit b650e17 into anza-xyz:master Jan 10, 2025
51 checks passed
@pgarg66 pgarg66 deleted the limit-pub branch January 10, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones approved these changes

@Lichtso Lichtso Lichtso approved these changes

@LucasSte LucasSte Awaiting requested review from LucasSte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgarg66 @Lichtso @tao-stones