Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: empty_line_after_outer_attr #4397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brooksprumo
Copy link

Problem

New clippy lints when upgrading to rust 1.84.0.

warning: empty line after outer attribute
   --> zk-sdk/src/sigma_proofs/pod.rs:125:1
    |
125 | / #[cfg(not(target_os = "solana"))]
126 | |
    | |_^
127 |   impl TryFrom<PodGroupedCiphertext2HandlesValidityProof> for GroupedCiphertext2HandlesValidityProof {
    |   -------------------------------------------------------------------------------------------------- the attribute applies to this implementation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr
    = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default
    = help: if the empty line is unintentional remove it

Summary of Changes

Resolve the lints by using the suggestions from clippy and checking the code.

Partially fixes #4380

@brooksprumo brooksprumo marked this pull request as ready for review January 10, 2025 16:38
@brooksprumo brooksprumo added the automerge automerge Merge this Pull Request automatically once CI passes label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New clippy lints in Rust 1.84.0
1 participant