implements From<ContactInfo> for CrdsData #4405
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anza-xyz#4391 adds type parameter to gossip ContactInfo, but CrdsData::ContactInfo(_) can only be initialized with a specific type. In order to simplify the change and avoid verbosity, this commit implements From<ContactInfo> for CrdsData which allows to generically handle different types without changing the call sites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#4391 adds type parameter to gossip
ContactInfo, butCrdsData::ContactInfo(_)can only be initialized with a specific type.Summary of Changes
In order to simplify the change and avoid verbosity, this commit implements
From<ContactInfo>forCrdsDatawhich allows to generically handle different types without changing the call sites.