Wen restart: play unfrozen block #4626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
previously approved these changes
Jan 24, 2025
wen-restart/src/wen_restart.rs
Outdated
Comment on lines
622
to
631
| let bank_with_scheduler = if let Some(bank) = saved_bank { | ||
| bank | ||
| } else { | ||
| let new_bank = Bank::new_from_parent( | ||
| parent_bank.clone(), | ||
| &leader_schedule_cache | ||
| .slot_leader_at(slot, Some(&parent_bank)) | ||
| .unwrap(), | ||
| slot, | ||
| ); |
There was a problem hiding this comment.
maybe simpler to do
let bank_with_scheduler = saved_bank.unwrap_or_else(|| {
let leader = leader_schedule_cache
.slot_leader_at(slot, Some(&parent_bank))
.expect("Failed to get slot leader");
Bank::new_from_parent(&parent_bank, &leader, slot)
});
There was a problem hiding this comment.
Done, ready for another look
carllin
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes blocks may be in bank_forks but not frozen yet before the restart, need to replay them.