Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote cu Vote, Withdraw, UpdateValidatorIdentity #4733

Merged
merged 7 commits into from
Feb 9, 2025
Merged

Vote cu Vote, Withdraw, UpdateValidatorIdentity #4733

merged 7 commits into from
Feb 9, 2025
+582 −4

Conversation

ksolana
Copy link

@ksolana ksolana commented Feb 1, 2025 •
edited
Loading

Vote instruction

Part of: #3364

Benchmarking vote_instruction_initialize_account: Collecting 100 samples in estimated 5.0408 s
vote_instruction_initialize_account
                        time:   [18.325 µs 18.345 µs 18.372 µs]
                        change: [+0.4780% +0.7014% +0.8958%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 21 outliers among 100 measurements (21.00%)
  1 (1.00%) high mild
  20 (20.00%) high severe

Benchmarking vote_instruction_authorize: Collecting 100 samples in estimated 5.0804 s (273k it
vote_instruction_authorize
                        time:   [18.644 µs 18.663 µs 18.687 µs]
                        change: [+0.7263% +0.9232% +1.1086%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 8 outliers among 100 measurements (8.00%)
  3 (3.00%) high mild
  5 (5.00%) high severe

Benchmarking vote_instruction_vote: Collecting 100 samples in estimated 5.0636 s (66k iteratio
vote_instruction_vote   time:   [76.919 µs 76.962 µs 77.015 µs]
                        change: [-0.7997% -0.6886% -0.5740%] (p = 0.00 < 0.05)
                        Change within noise threshold.

Benchmarking vote_instruction_withdraw: Collecting 100 samples in estimated 5.0651 s (278k ite
vote_instruction_withdraw
                        time:   [18.180 µs 18.189 µs 18.203 µs]
                        change: [-0.2169% -0.1615% -0.0898%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) high mild
  4 (4.00%) high severe

Benchmarking vote_update_validator_identity: Collecting 100 samples in estimated 5.0486 s (283
vote_update_validator_identity
                        time:   [17.814 µs 17.834 µs 17.858 µs]
                        change: [+0.3628% +0.4846% +0.6172%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 9 outliers among 100 measurements (9.00%)
  7 (7.00%) high mild
  2 (2.00%) high severe

Benchmarking vote_update_commission: Collecting 100 samples in estimated 5.0731 s (283k iterat
vote_update_commission  time:   [17.898 µs 17.907 µs 17.918 µs]
                        change: [+1.3546% +1.4389% +1.5243%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
  2 (2.00%) high mild
  3 (3.00%) high severe

vote_vote_switch        time:   [77.604 µs 77.625 µs 77.650 µs]
                        change: [+0.5989% +0.6810% +0.7646%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 15 outliers among 100 measurements (15.00%)
  1 (1.00%) low severe
  5 (5.00%) high mild
  9 (9.00%) high severe

Benchmarking vote_authorize_checked: Collecting 100 samples in estimated 5.0527 s (273k iterat
vote_authorize_checked  time:   [18.481 µs 18.493 µs 18.508 µs]
                        change: [+1.5542% +1.6245% +1.7116%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
  6 (6.00%) high mild
  6 (6.00%) high severe

Benchmarking vote_update_vote_state: Collecting 100 samples in estimated 5.1025 s (66k iterati
vote_update_vote_state  time:   [78.007 µs 78.094 µs 78.211 µs]
                        change: [+1.4626% +1.6035% +1.7294%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
  5 (5.00%) high mild
  6 (6.00%) high severe

Benchmarking vote_update_vote_state_switch: Collecting 100 samples in estimated 5.1086 s (66k 
vote_update_vote_state_switch
                        time:   [77.950 µs 77.966 µs 77.987 µs]
                        change: [+0.1141% +0.2348% +0.3286%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 12 outliers among 100 measurements (12.00%)
  1 (1.00%) low mild
  5 (5.00%) high mild
  6 (6.00%) high severe

@ksolana ksolana force-pushed the vote_cu branch 3 times, most recently from 15c5f09 to c1adafb Compare February 1, 2025 23:22
@ksolana ksolana marked this pull request as ready for review February 1, 2025 23:23
@ksolana ksolana force-pushed the vote_cu branch 5 times, most recently from 3f4e8e4 to 26ead6a Compare February 4, 2025 05:32
@ksolana ksolana changed the title Vote cu bench_vote Vote cu Vote, Withdraw, UpdateValidatorIdentity Feb 4, 2025
@ksolana ksolana force-pushed the vote_cu branch 2 times, most recently from 4ed5e1f to 56a174d Compare February 4, 2025 14:19
tao-stones
tao-stones reviewed Feb 4, 2025
View reviewed changes
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you please post bench results?

@ksolana
Copy link
Author

ksolana commented Feb 5, 2025

Looks good, can you please post bench results?

added

@ksolana ksolana force-pushed the vote_cu branch 3 times, most recently from f7aa877 to ee53ccd Compare February 8, 2025 03:57
@ksolana ksolana merged commit dd4c765 into anza-xyz:master Feb 9, 2025
47 checks passed
@ksolana ksolana deleted the vote_cu branch February 9, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones left review comments

@KirillLykov KirillLykov KirillLykov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ksolana @KirillLykov @tao-stones