add validation of allowed CrdsValues in gossip #4764
+37
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protocol enum variants can now be pruned better in Sanitize impl
alexpyattaev
force-pushed
the
ping_size
branch
from
4691581 to
d7dd5f3
Compare
gregcusack
reviewed
Feb 3, 2025
Comment on lines
+170
to
+172
| CrdsData::LegacyVersion(_) => { | ||
| return Err(SanitizeError::InvalidValue); | ||
| } |
There was a problem hiding this comment.
@behzadnouri, do we still need to support LegacyVersion? If not, maybe it makes sense to remove it from CrdsData as well.
Comment on lines
+182
to
+192
| for v in val { | ||
| match v.data() { | ||
| CrdsData::LegacyVersion(_) => { | ||
| return Err(SanitizeError::InvalidValue); | ||
| } | ||
| _ => { | ||
| v.sanitize()?; | ||
| } | ||
| } | ||
| } | ||
| Ok(()) |
There was a problem hiding this comment.
if we are going to reject LegacyVersion, I would just reject and return an error here:
Line 92 in 15a9d9c
There was a problem hiding this comment.
I guess so, yes. The question is what is the standard of proof to properly deprecate it for good.
Style change for PullRequest sanitize. Co-authored-by: Greg Cusack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol enum variants can now be pruned better in Sanitize impl
Problem
Sanitize implementation allowed certain invalid PullRequest variants to travel through the code
Summary of Changes