Improve logging of simulate-block-prodution #4773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
force-pushed
the
simulate-block-production-logging
branch
from
42e6ee4 to
b1380cc
Compare
apfitzge
reviewed
Feb 4, 2025
core/src/banking_simulation.rs
Outdated
| ); | ||
| } | ||
|
|
||
| fn log_ongoing_bank_cost(&self, bank: &Bank) { | ||
| fn log_ongoing_bank_cost(&self, bank: &Bank, bank_elapsed: Duration) { | ||
| debug!( |
There was a problem hiding this comment.
trying to think if there's a situation for simulation where we wouldn't want this to be logged. i.e. should we just switch this to info so its logged by default for simulation?
I'd lean towards yes.
There was a problem hiding this comment.
nice suggestion!: 70b3758
ryoqun
force-pushed
the
simulate-block-production-logging
branch
from
70b3758 to
fe470e2
Compare
apfitzge
approved these changes
Feb 5, 2025
ryoqun
added
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ledger-tool simulate-block-productionneeds some more love to create these charts without any out-of-tree patches: https://docs.google.com/spreadsheets/d/1agMkAyGBIcdugkc8z3v7xPwV5L1Zu3zVA41fxYDPClQ/edit?usp=sharingSummary of Changes
At first step, apply these logging cleanups from #2325.