Run clean based on time, not slots#6397
Merged
brooksprumo merged 2 commits intoanza-xyz:masterfrom Jun 5, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6397 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 848 848
Lines 379482 379483 +1
=========================================
- Hits 314521 314326 -195
- Misses 64961 65157 +196 🚀 New features to boost your workflow:
|
brooksprumo
force-pushed
the
abs/last-cleaned-time
branch
from
7d0a399 to
32cbabb
Compare
brooksprumo
force-pushed
the
abs/last-cleaned-time
branch
from
32cbabb to
9a17d03
Compare
brooksprumo
force-pushed
the
abs/last-cleaned-time
branch
from
9a17d03 to
d2296a6
Compare
HaoranYi
reviewed
Jun 4, 2025
roryharr
approved these changes
Jun 4, 2025
fkouteib
pushed a commit
to fkouteib/agave
that referenced
this pull request
Jun 7, 2025
mircea-c
pushed a commit
to mircea-c/agave
that referenced
this pull request
Jun 12, 2025
mircea-c
added a commit
to mircea-c/agave
that referenced
this pull request
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The main problem is #6295. As a means to that end, we need to ensure we don't clean past any enqueued snapshot request's slot.
Once we track the highest cleanable slot, we'll want to use that for setting how much to clean. This will not map to the current model where we always clean up to the current rooted bank's slot. As such, the "clean after 100 slots" check won't really make sense.
Summary of Changes
Instead, clean after a set amount of time, not slots.