v2.3: Refactors AccountsBackgroundService if a snapshot request was not handled (backport of #6418)#6451
Merged
brooksprumo merged 1 commit intov2.3from Jun 9, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2.3 #6451 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 848 848
Lines 379479 379490 +11
=======================================
+ Hits 314504 314523 +19
+ Misses 64975 64967 -8 🚀 New features to boost your workflow:
|
|
@Mergifyio rebase |
Author
✅ Branch has been successfully rebased |
brooksprumo
force-pushed
the
mergify/bp/v2.3/pr-6418
branch
from
e11bec4 to
ed21f9d
Compare
roryharr
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The main problem is #6295. As a means to that end, we need to ensure we don't clean past any enqueued snapshot request's slot.
Since we call
flushandcleanin multiple branches (if a snapshot request is not handled), it's not straight forward to share a "max cleanable slot" between them all.Summary of Changes
Refactor the AccountsBackgroundService code, when a snapshot request was not handled, to make it possible to share a "max cleanable slot".
Justification to Backport
This is required as part of the patches to fix #6295.
This is an automatic backport of pull request #6418 done by [Mergify](https://mergify.com).