Removes OldStoragesPolicy#6492
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Jun 11, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6492 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 847 847
Lines 379702 379622 -80
=======================================
+ Hits 314484 314486 +2
+ Misses 65218 65136 -82 🚀 New features to boost your workflow:
|
brooksprumo
force-pushed
the
old-storages-policy
branch
from
983c760 to
416e884
Compare
HaoranYi
reviewed
Jun 11, 2025
|
|
||
| /// Returns how clean_accounts() should handle old storages | ||
| pub fn clean_accounts_old_storages_policy(&self) -> OldStoragesPolicy { | ||
| if self.are_ancient_storages_enabled() { |
There was a problem hiding this comment.
are_ancient_storages_enabled is the next to clean up?
Author
There was a problem hiding this comment.
Once rent collection is gone. It's too intertwined otherwise, imo. I've tried 3+ separate times and have given up each time.
roryharr
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Now that skipping rewrites is enabled, ancient storages are also enabled. We no longer need special handling in
cleanfor storages older than an epoch when we were doing rewrites.Summary of Changes
Removes OldStoragesPolicy.
OldStoragesPolicy was originally added in #3737.