v2.3: Do not clean past enqueued snapshot request in AccountsBackgroundService (backport of #6437)#6497
Merged
brooksprumo merged 1 commit intov2.3from Jun 11, 2025
Merged
Conversation
t-nelson
approved these changes
Jun 11, 2025
| } | ||
|
|
||
| /// Returns the slot of the next snapshot request to be handled | ||
| fn peek_next_snapshot_request_slot(&self) -> Option<Slot> { |
There was a problem hiding this comment.
i was going to comment about "peek" usually being side-effect free, but then i looked under the hood and realized it's all side-effects down there and we're just keeping the status quo
HaoranYi
approved these changes
Jun 11, 2025
roryharr
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Please see #6295.
Summary of Changes
Do not clean past enqueued snapshot request.
Justification to Backport
Panics are being reported on v2.2 (and v2.3). So we need to backport if we want to fix the issue.
This is an automatic backport of pull request #6437 done by [Mergify](https://mergify.com).