SIMD-0391: Feature-gate fixed-point stake math#9637
Draft
grod220 wants to merge 1 commit intoanza-xyz:masterfrom
Draft
SIMD-0391: Feature-gate fixed-point stake math#9637grod220 wants to merge 1 commit intoanza-xyz:masterfrom
grod220 wants to merge 1 commit intoanza-xyz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current stake warmup/cooldown calculations use floating-point arithmetic which blocks the stake program from being compatible with the upstream bpf toolchain. SIMD-0391 specifies a transition to fixed-point integer math which is implemented in the
solana-stake-interfacecrate. In this PR, these exposed methods are feature gated. All validator clients and the stake program itself will need to be updated in lock step.Summary of Changes
stake_program_fixed_point_warmup_cooldownRollout plan
Feature Gate Issue: #